Hide failover manual cleanup for auto-cleanup VMs

[TimothyAsirJeyasing]

Fleet-protected VMs (vm-recipe) clean up source resources automatically after failover, so the discovered-app Attention warning is misleading. Keep the message for other discovered apps and when AutoCleanup is NotFeasible.

Bug Refs DFBUGS-8006

Description

---

Change Type

Please select all applicable options:

• Feature
• Bug Fix
• Improvement
• Refactor
• Tests

---

Component / Area Impacted

Please select all applicable options:

• ODF
• FDF
• Client
• MCO
• Fusion Access (SAN Storage)
• CNSA (Remote Mount)
• E2E Test

---

Screenshots / Recordings

Screenshots

For the Non-VM application or the VM application with NotFeasible

For the VM application with Feasible

Recordings / Demo Videos

---

Testing

Please select the type of tests included:

• Unit Tests
• E2E Tests
• No Tests Required (with justification below)

---

Additional Notes

Summary by CodeRabbit

• Bug Fixes
  • Failover warnings now show manual-cleanup guidance only when cleanup is required.
  • Fleet-protected virtual machines no longer display an unnecessary manual-cleanup message.
  • Manual-cleanup guidance remains visible when automatic cleanup is not feasible.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TimothyAsirJeyasing
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• packages/mco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b11bf18e-c7d8-460e-8677-681b558cf736

📥 Commits

Reviewing files that changed from the base of the PR and between 3cd5e98 and c6c596a.

📒 Files selected for processing (3)

• packages/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.spec.tsx
• packages/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.tsx
• packages/mco/types/ramen.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The failover parser now shows the manual-cleanup warning based on the DRPC recipe and AutoCleanup condition. The VRGConditionReason enum includes NotFeasible, and tests cover both warning visibility cases.

Changes

Failover cleanup warning

Layer / File(s)	Summary
Manual cleanup decision logic packages/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.tsx, packages/mco/types/ramen.ts	The parser checks the DRPC recipe and AutoCleanup condition before rendering the manual-cleanup warning. VRGConditionReason.NotFeasible is now defined.
Failover warning tests packages/mco/components/modals/app-failover-relocate/parser/discovered-application-parser.spec.tsx	Tests verify that Fleet-protected VMs hide the warning and that a NotFeasible AutoCleanup condition shows it.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix

Suggested reviewers: vbnrh

Merge Risk: ⚪ Minimal · up to c6c59

The failover dialog now hides the cleanup instruction for VM recipes and retains it when automatic cleanup is not feasible. No current merge-blocking risk was identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: hiding the failover manual-cleanup message for VMs that use automatic cleanup.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}