Repository navigation
Conversation
GitHub: follow-up red-data-toolsGH-29 Because tests must not change user data. Only `test_clear_cache` still changes the real system cache with a dedicated cache ID (red-remote-input-test) because `RemoteInput#clear_cache` does not use `RemoteInput#path`.
kou
reviewed
Oct 11, 2026
Comment on lines
+97
to
+99
| input.define_singleton_method(:path) do | ||
| sandbox_path | ||
| end |
Member
There was a problem hiding this comment.
Hmm. Can we change CachePath#system_cache_path instead? We may want to add a new environment variable such as RED_REMOTE_INPUT_CACHE_DIR for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub: follow-up GH-29
Because tests must not change user data.
Only
test_clear_cachestill changes the real system cache with a dedicated cache ID (red-remote-input-test) becauseRemoteInput#clear_cachedoes not useRemoteInput#path.