Repository navigation
Remove NullToStrictStringIntConverter, use explicit null type in null-to-strict rules - #8837
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the null-to-strict rules to only act on an explicit null argument type, dropping the shared
NullToStrictStringIntConverternode manipulator and its(string)/(int)casting of maybe-null/mixed/ternary values.Affected rules:
ArrayKeyExistsNullToEmptyStringRector- null key ->''NullToStrictStringFuncCallArgRector- null arg ->''NullToStrictIntPregSlitFuncCallLimitArgRector- null limit ->0The
NullToStrictStringIntConvertermanipulator is removed; its cast-based cases are now left untouched and covered byskip_*fixtures.