Repository navigation
[perf] Drop re-processing guard, iterate rules to a fixed point - #8679
Merged
Merged
Conversation
TomasVotruba
force-pushed
the
tv-node-traverser-5
branch
2 times, most recently
from
October 16, 2026 20:02
6aa67f0 to
917b4df
Compare
TomasVotruba
marked this pull request as draft
October 16, 2026 20:17
TomasVotruba
force-pushed
the
tv-node-traverser-5
branch
14 times, most recently
from
October 19, 2026 17:23
b2a147b to
84c44de
Compare
Remove CreatedByRuleDecorator and its per-pass guard in RectorRunner; FileProcessor now iterates rules to a fixed point, refreshing scope on re-processed class and else nodes so repeated passes keep a valid scope.
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-node-traverser-5
branch
from
October 19, 2026 17:40
84c44de to
0751d88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the per-pass re-processing guard and lets the fixed-point loop do the work instead.
CreatedByRuleDecoratorand itsSkipper::shouldSkipCurrentNode()guard inRectorRunner- rules no longer hard-skip a node they already touched in an earlier passFileProcessoriterates rules to a fixed point, so a node changed by one rule is re-offered to the others until nothing changesChangedNodeScopeRefresherwrapsElse_/ElseIf_into anIf_before refresh - PHPStan only scopes those as part of anIf_, so their body statements kept a valid scope across repeated passes