Skip to content

[CodeQuality] Deprecate InnerFunctionToPrivateMethodRector - #8621

Merged
TomasVotruba merged 2 commits into
mainfrom
tv-deprecate-inner-function-to-private-method
Oct 11, 2026
Merged

TomasVotruba merged 2 commits into
mainfrom
tv-deprecate-inner-function-to-private-method

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Deprecates InnerFunctionToPrivateMethodRector.

Moving an inner named function to a private method is a niche transformation that can change behavior in undesired ways (scope, call semantics, string-callable usage), so it needs a human check rather than an automated rule.

  • mark rule with DeprecatedInterface + @deprecated, gut the body to throw
  • remove its tests
  • unregister from CodeQualityLevel

@TomasVotruba
TomasVotruba merged commit 59c2cd5 into main Oct 11, 2026
49 checks passed
@TomasVotruba
TomasVotruba deleted the tv-deprecate-inner-function-to-private-method branch October 11, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant