[deprecation] Deprecate CallUserFuncWithArrowFunctionToInlineRector as niche rule, not part of PHP upgrade path

rules/CodeQuality/Rector/FuncCall/CallUserFuncWithArrowFunctionToInlineRector.php

@@ -5,25 +5,18 @@
 namespace Rector\CodeQuality\Rector\FuncCall;
 
 use PhpParser\Node;
-use PhpParser\Node\Arg;
-use PhpParser\Node\Expr\ArrowFunction;
-use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\FuncCall;
-use Rector\Php74\NodeAnalyzer\ClosureArrowFunctionAnalyzer;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
 use Rector\RuleDoc\RuleDefinition;
 
 /**
- * @see \Rector\Tests\CodeQuality\Rector\FuncCall\CallUserFuncWithArrowFunctionToInlineRector\CallUserFuncWithArrowFunctionToInlineRectorTest
+ * @deprecated This rule is deprecated, as it handles a niche call_user_func() with arrow function case that is not part of the PHP upgrade path.
  */
-final class CallUserFuncWithArrowFunctionToInlineRector extends AbstractRector
+final class CallUserFuncWithArrowFunctionToInlineRector extends AbstractRector implements DeprecatedInterface
 {
-    public function __construct(
-        private readonly ClosureArrowFunctionAnalyzer $closureArrowFunctionAnalyzer
-    ) {
-    }
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Refactor `call_user_func()` with arrow function to direct call', [
@@ -65,37 +58,9 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node->isFirstClassCallable()) {
-            return null;
-        }
-
-        if (! $this->isName($node, 'call_user_func')) {
-            return null;
-        }
-
-        if (count($node->args) !== 1) {
-            return null;
-        }
-
-        // change the node
-        if (! isset($node->getArgs()[0])) {
-            return null;
-        }
-
-        $firstArg = $node->args[0];
-        if (! $firstArg instanceof Arg) {
-            return null;
-        }
-
-        $firstArgValue = $firstArg->value;
-        if ($firstArgValue instanceof ArrowFunction) {
-            return $firstArgValue->expr;
-        }
-
-        if ($firstArgValue instanceof Closure) {
-            return $this->closureArrowFunctionAnalyzer->matchArrowFunctionExpr($firstArgValue);
-        }
-
-        return null;
+        throw new ShouldNotHappenException(sprintf(
+            '"%s" rule is deprecated, as it handles a niche call_user_func() with arrow function case that is not part of the PHP upgrade path',
+            self::class
+        ));
     }
 }

src/Config/Level/CodeQualityLevel.php

@@ -34,7 +34,6 @@
 use Rector\CodeQuality\Rector\Foreach_\ForeachToInArrayRector;
 use Rector\CodeQuality\Rector\Foreach_\SimplifyForeachToCoalescingRector;
 use Rector\CodeQuality\Rector\FuncCall\ArrayMergeOfNonArraysToSimpleArrayRector;
-use Rector\CodeQuality\Rector\FuncCall\CallUserFuncWithArrowFunctionToInlineRector;
 use Rector\CodeQuality\Rector\FuncCall\ChangeArrayPushToArrayAssignRector;
 use Rector\CodeQuality\Rector\FuncCall\CompactToVariablesRector;
 use Rector\CodeQuality\Rector\FuncCall\InlineIsAInstanceOfRector;
@@ -159,7 +158,6 @@ final class CodeQualityLevel
         TernaryFalseExpressionToIfRector::class,
         SwitchTrueToMatchRector::class,
         SimplifyIfNullableReturnRector::class,
-        CallUserFuncWithArrowFunctionToInlineRector::class,
         FlipTypeControlToUseExclusiveTypeRector::class,
         InlineArrayReturnAssignRector::class,
         RemoveAlwaysElseRector::class,