Repository navigation
[TypeDeclaration] Speed up BinaryOpNullableToInstanceofRector by skipping bool-shaped operands - #8607
Merged
Merged
Conversation
…s in BinaryOpNullableToInstanceofRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perf
BinaryOpNullableToInstanceofRectorfires on everyBooleanAnd/BooleanOrand callsresolveNullableObjectType()(which runs full native type resolution) on both operands. An operand that is itself bool/scalar-shaped can never be a nullable object, so that type resolution is wasted - most notably in chained conditions like$a && $b && $c, which parse as($a && $b) && $cwhere the left operand is a nestedBooleanAnd.Added a cheap structural guard that skips
resolveNullableObjectType()when the operand is aBinaryOp,BooleanNot,Instanceof_,Empty_orIsset_. These always resolve to a non-object type, so the result is unchanged - only the scope lookup is avoided.