Repository navigation
Dedupe skip match resolution per file in RectorRunner - #8590
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipper::matchSkip($rector, $filePath)is node-independent - it depends only on the rule and the file, not the visited node. It was being called for every node of every rule, re-running reflection and class-skip resolution each time.Cache the result per (file, rule) in
RectorRunner, resetting the cache when a new file is processed. The clone-probe andmarkSkipUsedbookkeeping still run per node, so skip semantics and unused-skip reporting are unchanged.The class drops the
readonlykeyword to hold the small cache; dependencies stayreadonlyindividually.