Repository navigation
[perf] Skip scope fetch in RemoveUnusedNonEmptyArrayBeforeForeachRector unless if-with-only-foreach - #8581
Merged
Conversation
…or unless if-with-only-foreach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
If_branch ofrefactor()fetched the PHPStan scope for everyIf_node. The only structural shape the rule acts on is an if-with-only-foreach, whichIfManipulator::isIfWithOnly()detects without a scope.Hoisting that cheap check above
ScopeFetcher::fetch()lets the vast majority ofIf_nodes bail out before any scope resolution.