Skip to content

[perf] Skip reflection in RemoveUnusedPrivateMethodRector when no private method #8579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Oct 10, 2026
Merged

[perf] Skip reflection in RemoveUnusedPrivateMethodRector when no private method #8579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e9d657
[perf] Skip reflection in RemoveUnusedPrivateMethodRector when class …
TomasVotruba Oct 10, 2026
cd17b85
[ci-review] Rector Rectify
actions-user Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions rules/DeadCode/Rector/ClassMethod/RemoveUnusedPrivateMethodRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ public function getNodeTypes(): array
*/
public function refactor(Node $node): ?Node
{
if ($node->getMethods() === []) {
// unreliable to detect on anonymous class: doesn't make sense
if ($node->isAnonymous()) {
return null;
}

// unreliable to detect on anonymous class: doesn't make sense
if ($node->isAnonymous()) {
if (! $this->hasPrivateMethod($node)) {
return null;
}

Expand Down Expand Up @@ -145,6 +145,11 @@ public function refactor(Node $node): ?Node
return null;
}

private function hasPrivateMethod(Class_ $class): bool
{
return array_any($class->getMethods(), fn(ClassMethod $classMethod): bool => $classMethod->isPrivate());
}

private function shouldSkip(ClassMethod $classMethod, ClassReflection $classReflection): bool
{
// unreliable to detect trait, interface: doesn't make sense
Expand Down
Loading