Repository navigation
[perf] Respect cgroup/CFS CPU quota in parallel worker count - #8559
Merged
Merged
Conversation
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CpuCoreCountProviderused fidrygetCount(), which reports host logical cores and ignores cgroup/CFS CPU quota. In containers (docker run --cpus=N,KUBERNETES_CPU_LIMIT) this overcommits workers against the quota the scheduler actually enforces.Switched to
getAvailableForParallelisation()->availableCpus, whose default count-limit finder already reads the cgroup quota andKUBERNETES_CPU_LIMIT. On a host with no quota the value is unchanged.The previous
NumberOfCpuCoreNotFoundcatch is dropped becausegetAvailableForParallelisation()falls back internally and does not throw it.