[Caching] Cache dry-run files whose FileDiff has no content change - #8523
Merged
TomasVotruba merged 1 commit intoOct 1, 2026
Merged
TomasVotruba merged 1 commit into
TomasVotruba merged 1 commit into
Conversation
FileProcessor creates a FileDiff for reported line changes even when the printed content is unchanged, so such files were never cached in dry-run. Gate caching on FileProcessResult::hasChanged() instead.
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #6794,
FileProcessorcreates aFileDiffwhen rules report line changes, even if the printed content is unchanged (e.g.NameImportingPostRectoron an aliased import with the same short name). The dry-run cache gate treats anyFileDiffas a change, so these files are never cached and are re-processed on every--dry-run.This gates caching on
FileProcessResult::hasChanged()instead.Tests:
testDryRunCachesFileWhoseReportedChangesLeaveContentUnchanged: fails onmaintestDryRunDoesNotCacheFileWithPendingChanges: files with real changes stay uncached