RDKEMW-17483: Change Discovery.watched and Metrics methods return type

[swethasukumarr]

No description provided.

[Copilot]

Pull request overview

This PR updates the Discovery watched() API and multiple Metrics event APIs to return Result<void> (instead of Result<bool>), aligning them with “fire-and-forget” invocation semantics rather than boolean-returning queries.

Changes:

• Changed Discovery.watched and most Metrics.* methods to return Result<void> and switched implementations from helper_.get<...> to helper_.invoke(...).
• Updated unit/component tests and demo apps to stop dereferencing boolean results and instead assert only success.
• Added a unit-test helper (mockInvoke) for mocking void-returning invocations.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
include/firebolt/metrics.h	Updates Metrics interface return types to Result<void> (docs need adjustment).
include/firebolt/discovery.h	Updates Discovery interface return type to Result<void> (docs need adjustment).
src/metrics_impl.h	Updates MetricsImpl overrides to Result<void>.
src/metrics_impl.cpp	Switches Metrics implementations from get<bool> to invoke and returns Result<void>.
src/discovery_impl.h	Updates DiscoveryImpl override to Result<void>.
src/discovery_impl.cpp	Switches watched() implementation to invoke and returns Result<void>.
test/unit/mock_helper.h	Adds mockInvoke() helper for void invocations.
test/unit/metricsTest.cpp	Updates unit tests to use mockInvoke() and stop checking boolean payloads.
test/unit/discoveryTest.cpp	Updates unit tests to use invoke and stop checking boolean results.
test/component/metricsTest.cpp	Updates component tests to only assert success (no expected boolean comparison).
test/component/discoveryTest.cpp	Updates component test to only assert success (currently missing gtest include).
test/api_test_app/apis/metricsDemo.cpp	Updates demo output to not print boolean result values.
test/api_test_app/apis/discoveryDemo.cpp	Updates demo output to not print boolean result values.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

[Copilot]

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

The base branch was changed.