RDKEMW-12856: throw early error when IRDB provides empty waveforms#236
Open
egalla204 wants to merge 1 commit into
Open
RDKEMW-12856: throw early error when IRDB provides empty waveforms#236egalla204 wants to merge 1 commit into
egalla204 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an early error log when the constructed IR waveforms map is empty, avoiding a call into programIrSignalWaveforms with no codes.
Changes:
- Detect empty
ir_codesmap prior to invoking the BLE RCU interface and log an error - Preserve existing failure logging when
programIrSignalWaveformsreturns false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a request for waveforms an IRDB can return an empty array with a successful status. This results in a successful call to the plugin method but an asynchronous failure as a status event later. Its better to return this as an error earlier to the plugin call since we can determine the error condition before sending to the remote.