Skip to content

Apply ExplicitNullableObjectInstanceRector - #166

Merged
rasuvaeff merged 1 commit into
masterfrom
fix/rector-explicit-nullable
Oct 26, 2026
Merged

rasuvaeff merged 1 commit into
masterfrom
fix/rector-explicit-nullable

Conversation

@rasuvaeff

Copy link
Copy Markdown
Owner

The Rector step in the Psalm job fails with rector 2.8.1 (15 files, ExplicitNullableObjectInstanceRector). It stayed hidden on master because the job is skipped by the changes filter, and surfaced on #163 which touches static-analysis.yml.

=== null on object-typed values becomes instanceof. In Runtime::dispatch the dead-assert rule removes the assert($sequence !== null) that psalm needs, so the narrowing moved into the condition. No behaviour change.

composer build and composer rector are green on PHP 8.5 locally.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fc50da5f-e9c1-48ac-b55b-b513fc0fa482
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rasuvaeff
rasuvaeff merged commit 87aab5a into master Oct 26, 2026
25 checks passed
@rasuvaeff
rasuvaeff deleted the fix/rector-explicit-nullable branch October 26, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant