Repository navigation
Build pushes on master only; pull requests build every change - #32
Merged
Merged
Conversation
The CI build ran on every push to any branch and on every pull request to master, so each push to a branch with an open pull request built the same code twice. Each run also counts towards the version number, which is the number of builds this month, so the duplicates used up version numbers. Pushes now build only on master, where the Release workflow takes its packages from. A change on its way to master is built by its pull request, against the merge result. workflow_dispatch builds any branch by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each push to a branch with an open pull request started two identical CI builds: one for the push, one for the pull request.
The cause
build.ymltriggered onpushto every branch ('**') and onpull_requestto master. A push to a branch with an open pull request matches both.Both runs build Release and Debug, run all tests and pack the NuGet packages. Each run also counts towards the version,
1.<year>.<month>.<builds this month>, so the duplicates used up version numbers as well.The change
workflow_dispatchbuilds any branch by hand from the Actions tab, for a branch without a pull request.Only the trigger section of
build.ymlchanges. The build steps and the version calculation are untouched.