Skip to content
This repository was archived by the owner on Sep 25, 2023. It is now read-only.

Fix complex type bug with correlate - #382

Open
mnicely wants to merge 1 commit into
rapidsai:branch-22.12from
mnicely:fix_correlate_bug
Open

Fix complex type bug with correlate#382
mnicely wants to merge 1 commit into
rapidsai:branch-22.12from
mnicely:fix_correlate_bug

Conversation

@mnicely

@mnicely mnicely commented May 26, 2021

Copy link
Copy Markdown
Contributor

Found a bug with correlate 1D + complex data types.

@mnicely mnicely added ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 26, 2021
@mnicely
mnicely requested a review from awthomp May 26, 2021 19:26
@mnicely mnicely self-assigned this May 26, 2021
@mnicely
mnicely requested a review from a team as a code owner May 26, 2021 19:26
@awthomp awthomp added the improvement Improvement / enhancement to an existing function label May 26, 2021
@awthomp

awthomp commented May 27, 2021

Copy link
Copy Markdown
Member

rerun tests

1 similar comment
@awthomp

awthomp commented Jun 1, 2021

Copy link
Copy Markdown
Member

rerun tests

@awthomp

awthomp commented Jun 2, 2021

Copy link
Copy Markdown
Member

@ajschmidt8 -- looks like CI is failing for the centos7 test that isn't related to this PR. Can we get this merged?

@ajschmidt8

ajschmidt8 commented Jun 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@awthomp I'm seeing a lot of failures (see screenshot) related to the test_convolution.py file which was touched in this PR. can you double-check the tests to ensure that they are correct?

image

@awthomp

awthomp commented Jun 3, 2021

Copy link
Copy Markdown
Member

D'oh! I missed this in the "Details" of the failed test log. My bad! I'll work with @mnicely to get this test passing before merge.

@awthomp
awthomp changed the base branch from branch-21.06 to branch-21.08 June 9, 2021 20:07
@github-actions

github-actions Bot commented Nov 23, 2021

Copy link
Copy Markdown

This PR has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates.

@github-actions

github-actions Bot commented Nov 23, 2021

Copy link
Copy Markdown

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@awthomp
awthomp changed the base branch from branch-21.08 to branch-22.12 November 21, 2022 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@awthomp awthomp awthomp approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@mnicely mnicely

Labels

3 - Ready for Review Ready for review by team ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround cpp improvement Improvement / enhancement to an existing function inactive-30d inactive-90d non-breaking Non-breaking change Python

Projects

cusignal
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mnicely @awthomp @ajschmidt8 @fondaing @caryr35