Skip to content

[API] deprecate cucim.skimage.morphology binary morphology functions #1051

Open

Description

@grlee77

scikit-image 0.26 has deprecated binary_erosion, binary_dilation, binary_opening and binary_closing. The greyscale morphology functions can cover the binary case. So far we did not do the same deprecation in cuCIM.

For cuCIM, I think the kernel performance is a bit better in the binary case, so just using the greyscale kernels (based on minimum/maximum filtering) is slower. So if we just naively do the deprecation it will cause a performance regression. We can still consider the deprecation, but in order to do it, we should keep the underlying kernel implementation and automatically dispatch to the faster binary kernel when possible from the greyscale morphology functions.

cupyx.scipy.ndimage also provides binary morphology functions, but they do not have built-in support for passing in a sequence of structuring elements (from cuCIM/skimage structuring element decomposition).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions