Update rainix to latest; drop vestigial deploy workflow#317
Conversation
Point the flake input at github:rainlanguage/rainix (was the legacy rainprotocol org) and re-lock to the latest rainix. Drop the now-dead pkgs let-binding and the unused self arg (via ...) so the touched flake passes deadnix/nixfmt. All 55 receipt tests pass under the updated toolchain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rain.vats is a library — it has no deployments of its own (consumers like st0x and cyclo deploy the contracts). The workflow invoked rainix-sol-artifacts against a script/Deploy.sol that no longer exists, so it deployed nothing. The remaining workflows (rainix.yaml, publish-soldeer.yaml) already use rainix reusables. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 40 minutes and 16 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR updates the Nix flake configuration to use the rainlanguage/rainix repository instead of rainprotocol/rainix and removes unused destructuring from the outputs function. Additionally, the manual Solidity artifacts workflow is deleted, likely superseded by tooling in the migrated rainix input. ChangesDevelopment infrastructure updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
testPythGetPriceNoOlderThan forked at latest with a 1h staleness window, so it reverted StalePrice whenever Pyth's pull-oracle BTC/USD price on Arbitrum hadn't been pushed within the hour — a pre-existing flake unrelated to the toolchain (an on-chain stored price; the forge version can't change it). The test only pins the live IPyth ABI / return decoding, not freshness, so widen the window to effectively unbounded. Pinning a fork block was rejected: it needs a full-archive RPC (public RPCs return 'missing trie node'). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Review verdict: APPROVEReviewed ad7a37b CI green (legal/static/test + CodeRabbit). Reviewed the full diff at head
Verdict: approve. Merging. |
What
Modernize rain.vats CI to the current rainix:
github:rainlanguage/rainix(was the legacyrainprotocolorg) and re-lock. Also drop the now-deadpkgslet-binding and the unusedselfarg (via...) so the touched flake passesdeadnix/nixfmt. All 55 receipt tests pass under the updated toolchain.manual-sol-artifacts.yaml— rain.vats is a library; it has no deployments of its own (consumers like st0x and cyclo deploy the contracts). The workflow invokedrainix-sol-artifactsagainst ascript/Deploy.solthat no longer exists, so it deployed nothing.Reusables
The two real workflows already call rainix reusables and are unchanged:
rainix.yaml→rainix-sol.yaml@mainpublish-soldeer.yaml→publish-soldeer.yaml@mainNo deploy
Deploy.sol/reusable is added because there is nothing for rain.vats to deploy.🤖 Generated with Claude Code
Summary by CodeRabbit
These changes streamline the development infrastructure and improve dependency management.