Skip to content

test(staleness): pin exact-timeout and just-stale LTS boundary tests #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedavidmeister wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test(staleness): pin exact-timeout and just-stale LTS boundary tests #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
622443d
test(staleness): pin exact-timeout and just-stale boundaries for LTS …
thedavidmeister Jun 30, 2026
4bc906b
fix(ci): rainix-sol-test empty-commit retrigger (flaky) [3b-attempt]
thedavidmeister Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions test/src/lib/lts/LibFtsoV2LTS.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,48 @@ contract LibFtsoV2LTSTest is Test {
feedConsumer.getFeedValue(ETH_USD_FEED_ID, 3600);
}

/// block.timestamp == feedTimestamp + timeout: the staleness check is strict `>`,
/// so this must succeed (not stale).
function testFtsoV2LTSGetFeedExactTimeoutNotStale() external {
vm.createSelectFork(LibFork.rpcUrlFlare(vm), BLOCK_NUMBER);

FeedConsumer feedConsumer = new FeedConsumer();
vm.warp(1729795768 + 3600);
uint256 value = feedConsumer.getFeedValue(ETH_USD_FEED_ID, 3600);
assertGt(value, 0);
}

/// block.timestamp == feedTimestamp + timeout + 1: one second past the boundary
/// must revert with StalePrice.
function testFtsoV2LTSGetFeedJustStale() external {
vm.createSelectFork(LibFork.rpcUrlFlare(vm), BLOCK_NUMBER);

FeedConsumer feedConsumer = new FeedConsumer();
vm.warp(1729795768 + 3600 + 1);
vm.expectRevert(abi.encodeWithSelector(StalePrice.selector, 1729795768, 3600));
feedConsumer.getFeedValue(ETH_USD_FEED_ID, 3600);
}

/// timeout == 0: any block.timestamp strictly after feedTimestamp is stale.
function testFtsoV2LTSGetFeedTimeoutZeroStale() external {
vm.createSelectFork(LibFork.rpcUrlFlare(vm), BLOCK_NUMBER);

FeedConsumer feedConsumer = new FeedConsumer();
vm.warp(1729795768 + 1);
vm.expectRevert(abi.encodeWithSelector(StalePrice.selector, 1729795768, 0));
feedConsumer.getFeedValue(ETH_USD_FEED_ID, 0);
}

/// timeout == 0 at exactly feedTimestamp: not stale (0 > 0 is false).
function testFtsoV2LTSGetFeedTimeoutZeroExactNotStale() external {
vm.createSelectFork(LibFork.rpcUrlFlare(vm), BLOCK_NUMBER);

FeedConsumer feedConsumer = new FeedConsumer();
vm.warp(1729795768);
uint256 value = feedConsumer.getFeedValue(ETH_USD_FEED_ID, 0);
assertGt(value, 0);
}

/// forge-config: default.fuzz.runs = 1
function testFtsoV2LTSGetFeedPaid(uint128 fee) external {
vm.assume(fee > 0);
Expand Down
Loading