test(parse-meta): assert PARSE_META matches dynamic rebuild from authoringMetaV2#229
Merged
Merged
Conversation
…eMetaV2 output Closes #17
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new test function was added to a Solidity test file to verify that dynamically rebuilding PARSE_META from authoringMetaV2() produces bytes identical to the statically-defined PARSE_META constant, along with supporting imports. ChangesPARSE_META drift-guard test
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…arse-meta-consistency
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
Adds
testParseMetaMatchesDynamicBuildtoERC4626Words.parseMeta.t.sol.The test calls
LibERC4626SubParser.authoringMetaV2(), decodes the result toAuthoringMetaV2[], passes it toLibGenParseMeta.buildParseMetaV2with the committedPARSE_META_BUILD_DEPTH, and asserts the output equals the committedPARSE_METAconstant.This ensures that drift between the hand-maintained parse meta binary and the source authoring metadata is caught at test time.
Summary by CodeRabbit