test(supportsInterface): assert both SubParser and Extern branches reachable via C3 linearization#215
test(supportsInterface): assert both SubParser and Extern branches reachable via C3 linearization#215thedavidmeister wants to merge 2 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 5 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new Forge test file ChangesERC4626Words supportsInterface test coverage
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…oling interface assertions Pins the remaining interface ids from both branches that ERC4626Words.meta.t.sol did not yet cover (ISubParserV4, IParserToolingV1, ISubParserToolingV1, IIntegrityToolingV1, IOpcodeToolingV1). Co-Authored-By: Claude <noreply@anthropic.com>
Closes #57
Closes #58
Closes #59
What
ERC4626Words.supportsInterfaceresolves the IERC165 diamond ambiguity betweenBaseRainlangSubParserandBaseRainlangExternby delegating tosuper.supportsInterfacewithoverride(BaseRainlangSubParser, BaseRainlangExtern). No test previously calledsupportsInterfaceon a deployed instance, so a regression that silently dropped one branch would have gone undetected.Adds
ERC4626WordsSupportsInterfaceTest(9 tests) asserting:ISubParserV4,IDescribedByMetaV1,IParserToolingV1,ISubParserToolingV1IInterpreterExternV4,IIntegrityToolingV1,IOpcodeToolingV1IERC165itself is reportedfalseMutation-validated:
return falsecauses 8/9 tests to fail.Co-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit