test(pointers): assert buildLiteralParserFunctionPointers returns empty bytes#213
Open
thedavidmeister wants to merge 1 commit into
Open
test(pointers): assert buildLiteralParserFunctionPointers returns empty bytes#213thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
…ty bytes ERC4626SubParser has no literal parser words, so buildLiteralParserFunctionPointers() returns "". Add testLiteralParserFunctionPointersEmpty() to the existing pointer consistency suite so a mutant returning non-empty bytes fails forge test without relying on an out-of-band diff. Closes #35 Closes #137 Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single test function, ChangesLiteral Parser Pointer Empty Test
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERC4626SubParserhas no literal parser words, sobuildLiteralParserFunctionPointers()always returns"". The existing pointer consistency suite (ERC4626Words.pointers.t.sol) tested all other build functions against their committed constants but was missing a test for the literal parser. This addstestLiteralParserFunctionPointersEmpty()to complete the suite.A mutant returning non-empty bytes from
buildLiteralParserFunctionPointers()now failsforge testwithout relying on an out-of-band diff.All 10 tests pass locally (
forge test --match-contract ERC4626WordsPointersTest).Closes #35
Closes #137
Co-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit