Skip to content
This repository was archived by the owner on Sep 13, 2017. It is now read-only.
This repository was archived by the owner on Sep 13, 2017. It is now read-only.

Silent errors when missing .js template, but .html exists #21

Description

@printercu

Hi!

There is */* in Accept header when remote requests are performed, so render in rails will render even html or any other templates. There is also known issue with suppressing error while executing script from response. So they both produces errors which are silent in production and can be detected in tests only either with complex browser tests, or with explicit format checks (I mean there is no exception at all when running post(path, params: params, xhr: true), in browser console too).

Do you think this behaviour should be fixed? I've found config.action_dispatch.ignore_accept_header, but it seems to appear only in 5.1.0 guides, and I don't think this is good solution for this case, as it works only for the whole app.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions