fix(symbolizer): Device driver misattribution#702
Open
rabbitstack wants to merge 1 commit into
Open
Conversation
EnumDevices() captures driver base/size at startup. If between enumeration and amd the first call stack capture, any driver shifted or reloaded, the base addresses in devs are stale. The address range check:could match the wrong driver if two drivers happen to have overlapping or adjacent ranges in your stale snapshot vs. reality. Mitigation steps: - Validate cache hits against current devs - Remove a stale driver if the new driver lives at the same base but different device path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR / why it is needed?
EnumDevices()captures driver base/size at startup. If between enumeration and and the first call stack capture, any driver shifted or reloaded, the base addresses in devs are stale. The address range check could match the wrong driver if two drivers happen to have overlapping or adjacent ranges in your stale snapshot vs. reality.Mitigation steps:
What type of change does this PR introduce?
/kind bug-fix (non-breaking change which fixes an issue)
Any specific area of the project related to this PR?
/area telemetry
Special notes for the reviewer
Does this PR introduce a user-facing change?