Repository navigation
fix(api): regenerate the operation catalog for the Qira'at endpoints - #95
Merged
Merged
Conversation
The `Release` job on `main` failed its `check:operation-catalogs` gate after #91 merged: the catalog was missing the Qira'at v4 operations added by #93. #91 was branched before #93 landed, so its catalog was regenerated against the older base and still passed on the PR, where the check only compares against that branch. The drift only became visible once both were on `main`. Regenerated with `pnpm --filter @quranjs/api generate:operation-catalogs`. Additive only: 55 lines covering the Qira'at readers, transmitters and junctures operations. No existing entry changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the
Releasejob onmain, which has been failing since #91 merged.What failed
Run: https://github.com/quran/api-js/actions/runs/38842902794
Why the PR check did not catch it
#91 (
sourceApponQuranReflectPost) was branched before #93 (Qira'at content API v4 endpoints) landed onmain. Its catalog was regenerated against the older base, socheck:operation-catalogspassed on the PR, where it only compares against that branch. The drift only existed once both changes were onmain, which is where the gate runs next.Nothing is wrong with either change. The generated artifact simply had not been rebuilt against the union of the two.
This change
Regenerated with
pnpm --filter @quranjs/api generate:operation-catalogs. Additive only, 55 lines, covering the Qira'at readers, transmitters and junctures operations. No existing entry is modified or removed.Verified locally:
node scripts/generate-operation-catalogs.mjs --checknow reportsGenerated operation catalogs are up to date.After this merges
The
Releasejob should publish the version of@quranjs/apicarryingsourceApp, which #91 added but never shipped.🤖 Generated with Claude Code