Report the correct column for an undefined global reference#1585
Merged
Conversation
A ReferenceError for an undefined global pointed at column 1 (or the start
of the enclosing function) rather than the column of the reference itself,
because the OP_get_var_undef opcode was emitted with the surrounding source
position.
Emit the identifier's own line and column so e.g. `function f(){ return
missingGlobal; }` points at `missingGlobal` instead of the function.
littledivy
force-pushed
the
fix/global-ref-column
branch
from
July 17, 2026 18:29
e337752 to
fa3d26e
Compare
saghul
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
ReferenceErrorfor an undefined global pointed at column 1 (or the start of the enclosing function) instead of the column of the reference itself, because the variable-load opcode was emitted with the surrounding source position.This emits the identifier's own line and column.
missingGlobal(col 4)let a=1; alsoMissing(col 10)function f(){ return missingGlobal; }Disclaimer: This is an AI-assisted patch from the v8x project.