Make Array.fromAsync elements enumerable#1581
Merged
Merged
Conversation
Array.fromAsync built its result with Object.defineProperty and no `enumerable` flag, so the elements defaulted to non-enumerable. The spec adds them with CreateDataPropertyOrThrow, which creates enumerable own data properties. As a result Object.keys(), spreads and for-in saw an empty array. Add `enumerable: true` to the property definitions and regenerate the precompiled builtin.
saghul
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array.fromAsyncbuilt its result withObject.definePropertyand noenumerableflag, so the elements defaulted to non-enumerable. The spec adds them with CreateDataPropertyOrThrow, which creates enumerable own data properties, soObject.keys(), spread andfor-inshould see them.Disclaimer: This is an AI-assisted patch from the v8x project.