stop rejected mutation steps early and fix the AVX-512 build - #987
Open
MZoxx wants to merge 1 commit into
Open
Conversation
MZoxx
force-pushed
the
verify-descent-abort
branch
from
August 23, 2026 15:09
f06f918 to
26477e0
Compare
MZoxx
force-pushed
the
verify-descent-abort
branch
from
August 23, 2026 16:11
26477e0 to
e11bbbd
Compare
cyber-pc
requested changes
Sep 4, 2026
cyber-pc
left a comment
cyber-pc
left a comment
Contributor
There was a problem hiding this comment.
The earlyAbort approach looks good to me, its gain ~1-2% on my 7950x.
Minor comment and you need to merge the develop branch into your branch to resolve the merge conflict.
|
|
||
| // bpp9000 scorer: recurrent ternary ANN (trits {0,1,2}, 2=UNKNOWN); only per-neuron LUTs mutate. | ||
| // Bit-exact with test/score_bpp9000_reference.h. | ||
| #if defined(__AVX512F__) && (defined(__AVX512VBMI__) || defined(_MSC_VER)) |
Contributor
There was a problem hiding this comment.
This change is good for Linux but please keep the original define, defined(__AVX512F__), to consolidate with code in qubic.cpp.
We will need some adjustment in case of only AVX512 supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.