Open
Conversation
hdonnay
force-pushed
the
bug/filterfs-concurrent
branch
from
f2205c0 to
9c530b4
Compare
crozzy
reviewed
Apr 29, 2026
Member
Author
|
Ah, yeah, I'm not sure this is testing the right thing now. Will rework a bit. |
The `TestDev` test used the machine's `/dev` directory to test special files getting filtered out. However when running concurrently with tests starting and stopping PostgreSQL, the test would flap on `shm` files disappearing from underneath it. This replaces the test with creating a socket in a test-created directory, which will not have files change unexpectedly. Signed-off-by: Hank Donnay <hdonnay@redhat.com> Change-Id: I43f94ee1f59234a423dfead4bccddbfb6a6a6964
hdonnay
force-pushed
the
bug/filterfs-concurrent
branch
from
9c530b4 to
39499d2
Compare
Member
Author
|
Updated:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TestDevtest used the machine's/devdirectory to test special files getting filtered out. However when running concurrently with tests starting and stopping PostgreSQL, the test would flap onshmfiles disappearing from underneath it.This replaces the test with creating a fifo in a test-created directory, which will not have files change unexpectedly.