fix: upgrade vulnerable JS dependencies (Aikido/Dependabot)#132
Merged
dorothyyzh merged 1 commit intoJul 24, 2026
Merged
Conversation
Bump direct vite ^5.4.19 -> ^5.4.21 and add scoped pnpm.overrides for transitive build/test tooling vulnerabilities. All flagged packages are dev/build-time only (not in the go:embed runtime bundle), so dist is not rebuilt. - form-data <4.0.6 -> 4.0.6 (QOR5-1495, CVE-2026-12143) - vite 5.4.19 -> 5.4.21 (QOR5-1774) - js-yaml <4.2.0 -> 4.3.0 (QOR5-2120) - glob@10 -> 10.5.0 (QOR5-2138) - rollup <4.59.0 -> 4.62.2 (QOR5-2521) - minimatch 9 -> 9.0.9, <3.1.4 -> 3.1.5 (QOR5-2533) - flatted <3.4.2 -> 3.4.2 (QOR5-2646) - picomatch <2.3.2 -> 2.3.2 (QOR5-2682) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
iBakuman
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All in the
corejs/pnpm sub-package. Bumped the directvitedevDep and added scopedpnpm.overridesfor transitive build/test-tooling vulnerabilities. Every flagged package is dev/build-time only — none are in the//go:embed corejs/dist/*.jsruntime bundle — so the committed dist bundle is intentionally not rebuilt (a plainvite buildalso drops the separately-vendoredvue.global.*.js, which would break the embed). The Dependabot alerts close on the lockfile change.<4.0.6→ 4.0.6^5.4.19→^5.4.21<4.2.0→ 4.3.0@10→ 10.5.0<4.59.0→ 4.62.29→9.0.9,<3.1.4→3.1.5<3.4.2→ 3.4.2<2.3.2→ 2.3.2Not fixed here (needs review)
vite(<= 6.4.1, needs a version > 6.4.2). This requires a vite 5 → 6 major upgrade, which cascades tovitest(^1.6.1 peers on vite 5) and other build plugins. Since vite is the bundler for the go:embed runtime bundle, a major bump needs a rebuild + review of the shippedindex.js. Left for a human. Note: this exact finding is auto-ignored in the qor5 Aikido workspace (dev-only, not reachable), so priority is low.Verification
pnpm install --frozen-lockfileclean (lockfile consistent with package.json).pnpm whyper package confirms no vulnerable version remains.pnpm buildpasses (type-check + vite build). dist deliberately not committed (see Summary).Deployment note
Skill does not merge or touch
release-*branches. Merging is per team policy.