fix(presets): center list editor row content and button within the row card#1095
Closed
Transmigration-zhou wants to merge 2 commits into
Closed
fix(presets): center list editor row content and button within the row card#1095Transmigration-zhou wants to merge 2 commits into
Transmigration-zhou wants to merge 2 commits into
Conversation
…tton When the row content is shorter than the 48px delete button (e.g. a single input), the flex row stretches the content column to the button's height and the content sticks to the top, leaving the button visibly below the input's centerline. Center the content column instead of stretching it; rows taller than the button are unaffected. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195isT8XZBhZ3wwcWTYKtgV
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go | Jul 7, 2026 3:43a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
The pt-4 pb-0 padding relied on the row content ending with a v-input details placeholder to supply the bottom gap; content without one (hide-details inputs, plain components) got pinned against the card's bottom border, off the card's centerline. Use pa-4 so the card's spacing no longer depends on the content's internal structure. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0195isT8XZBhZ3wwcWTYKtgV
Contributor
Author
|
Superseded by #1096 — same goal (center the delete button), but strictly scoped to the button via absolute positioning against the card; row content layout stays byte-for-byte unchanged, unlike the padding change here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #1094. Two remaining alignment defects in the list editor row cards (reported downstream in KGM-4586):
align-items: stretch) and sticks to its top — the button sits (48 − content)/2 px below the input's centerline.pt-4 pb-0padding relied on the row content ending with a v-input details placeholder to supply the bottom gap. Content without one (hide-details inputs, plain components) gets pinned against the card's bottom border, visibly off the card's vertical centerline.Fix
align-self-centeron the content column: a short content block centers against the button instead of stretching; rows taller than the button define the row height themselves and are unaffected.pa-4on the row card: symmetric vertical padding, so the card's spacing no longer depends on the content's internal structure. Rows whose content ends with a details placeholder gain 16px of bottom padding (16/36 total) — slightly roomier, but the card no longer collapses onto content that doesn't carry one.Testing
go test ./presets/...passes.go.modreplace: with hide-details inputs, both a single-input row and a two-field row measure a 0.0px offset between the delete button center and the card centerline.🤖 Generated with Claude Code