fix(playground): fold the navbar on a phone, and stop the sideways scroll - #32
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe playground navbar now groups secondary links and citation controls, adds a responsive mobile menu, and wires hamburger interaction. Narrow layouts also wrap selected controls and use a smaller panel logo. The vendored icon catalog includes the menu icon with an updated integrity hash. ChangesResponsive navbar
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant navbar-burger
participant wireNavbarMenu
participant navbar-more
User->>navbar-burger: Click hamburger
navbar-burger->>wireNavbarMenu: Toggle menu
wireNavbarMenu->>navbar-more: Update open state
wireNavbarMenu->>navbar-burger: Update aria-expanded
User->>navbar-more: Select navigation link
navbar-more->>wireNavbarMenu: Trigger close handling
wireNavbarMenu->>navbar-more: Close menu
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile only. Desktop layout is unchanged, verified at 900px and 1280px.
display: contentson a wide screen, so each link keeps one home. Data/Simulate and light/dark each collapse to the single button their two halves already agreed on; the status line ellipsises..recipe-head(logo + Form/YAML + the narrow-screen-only Show/Hide) measured 385px against 362px of column, which widened the single grid track and pushed every card past the viewport edge..frame-rowdid the same at ≤380px. Both rows now wrap, so neither can demand more than its widest item at any width.menuglyph and re-pinnedvendor/MANIFEST.json.Verified in headless Chrome (SwiftShader, so the app fully initialises) at 320/360/390/430/700/900/1280:
scrollWidth == clientWidthat every width, and the panel opens and closes on the button, an outside click, Escape, and picking a row.https://claude.ai/code/session_014Az5n7m3L8jXp4a1Xfq8hB
Summary by CodeRabbit