Repository navigation
Conversation
Isaac Lab v3.0.0 pins torch==2.11.0 and ships a torchrl extra, so the floor moves from 2.1 to 2.11 rather than 2.13. torch 2.11 and 2.12 are deprecated: importing torchrl on them raises a DeprecationWarning that names v0.17 as the release that requires torch>=2.13. The tensordict range is unchanged, so pip resolves tensordict 0.14.x on these versions. The native auto-reset compile test now requires torch 2.12, the first release where Dynamo traces the EnvBase key caches.
olddeps runs the declared minimum: torch 2.11.0 and torchvision 0.26.0 from the cu126 index on the cuda12.6.3 image, with hoptorch installed (the job installs with --no-deps) and the torch 2.1 setuptools<82 pin dropped. Release runs install tensordict<0.15, since 0.15 requires torch 2.13. mujoco-py now links from the checkout and gets libglew-dev. An autouse fixture resets the interaction type between tests, because the serial olddeps run let one leak into test_exploration. CLAUDE.md describes olddeps as the minimum versions.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4595
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Unclassified FailureAs of commit 5069dd0 with merge base e7a05a7 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises the torch floor from 2.1 to 2.11 and deprecates torch 2.11 and 2.12.
pyproject.tomlrequirestorch>=2.11.0a0. The tensordict range (>=0.14.2,<0.15.0) is unchanged, so pip resolves tensordict 0.14.3 on torch 2.11 and 2.12.Importing torchrl on torch<2.13 raises a
DeprecationWarningthat names v0.17 as the release that requires torch>=2.13 (_warn_if_torch_deprecatedintorchrl/_utils.py, tested intest/test_utils.py). This follows the two-release deprecation window.README and
docs/source/index.rststate the new floor and the deprecation.test_native_auto_reset_compile_step_and_maybe_resetnow requires torch 2.12: on 2.11, Dynamo cannot trace theself.__dict__.setdefaultof theEnvBasekey caches.olddeps runs the declared minimum: torch 2.11.0 and torchvision 0.26.0 from the cu126 index on
osdc-cuda:cuda12.6.3-cudnn-devel-ubuntu24.04. Moving it off torch 2.1 needed the following fixes:--no-deps;setuptools<82pin, which torch 2.1 needed;libglew-dev;test_exploration.CLAUDE.md 7c describes olddeps as the minimum supported versions.
I have raised an issue to propose this change (required for new features and bug fixes)
Types of changes
Testing
Local, macOS arm64, Python 3.12:
test_utils,test_auto_reset,test_exploration: 334 passed.test_ppo,test_sac,test_iql,test_specs,test_distributions: 5937 passed.test_import_warns_on_deprecated_torchpasses.uv pip compile(x86_64 manylinux, Python 3.12): tensordict 0.14.3 on torch 2.11 and 2.12, 0.15.1 on 2.13. Thevlaextra resolves lerobot 0.6.1 on torch 2.11.Known limitations
torchrl._torchrlis built against one torch ABI. A wheel built against a newer torch loads without its C++ extension on torch 2.11, soPrioritizedReplayBufferraisesSumSegmentTreeFp32 is not available([BUG] SumSegmentTreeFp32 not available #3508). Isaac Lab 3.0 users who need prioritized replay have to build torchrl from source until wheels are built per torch version.unittests-isaaclabjob still uses theisaac-lab:2.3.0image (Isaac Sim 5.1, torch 2.7, below this floor; torchrl is installed with--no-deps). Testing Isaac Lab 3.0 needs a follow-up job..github/ci_commit_pins/tensordict.txt, from before tensordict required torch 2.13) stays. Unpinning and moving to tensordict 0.15 belongs with the torch 2.13 floor in v0.17.implement_for("torch", ...)andTORCH_VERSIONchecks) are now dead code. Removing them is a follow-up.Checklist