Only set group and permissions on downloads dir if needed#391
Open
hugovk wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_release.py:During the 3.14.4 release, I held off uploading the files built by this repo (tarballs, docs, Android etc), awaiting some Windows build issues. This took some time. Once that was sorted, I continued.
But by this time, the macOS files had already been uploaded:
Usually, the tarballs etc. get there first, but the script fell over because Ned had already created the directories and set permissions, and my user could not do that:
After commenting out the
chgrp, thechmodalso fell over:So for the release I commented the
chmodas well.The proper fix is to check the group and permissions first, and only try setting them when needed.
Also refactored these similar calls for downloads + docs into
copy_and_set_permissions().add_to_pydotorg.py- replace calls likerun_cmd(["chmod", "644", sig_file])with directos.chmod(sig_file, 0o644)calls.