gh-148393: Use acquire load for _ma_watcher_tag in dict notify event#148509
Merged
colesbury merged 1 commit intopython:mainfrom Apr 13, 2026
Merged
gh-148393: Use acquire load for _ma_watcher_tag in dict notify event#148509colesbury merged 1 commit intopython:mainfrom
colesbury merged 1 commit intopython:mainfrom
Conversation
…event The watcher-bits read in _PyDict_NotifyEvent needs to use acquire to synchronize with the release from PyDict_Watch so that the callback publication is visible before the callback is invoked.
Contributor
Author
|
I missed this before, but I think we want to use acquire here so that any setup done before |
mpage
approved these changes
Apr 13, 2026
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 13, 2026
…event (pythongh-148509) The watcher-bits read in _PyDict_NotifyEvent needs to use acquire to synchronize with the release from PyDict_Watch so that the callback publication is visible before the callback is invoked. (cherry picked from commit 19f96f9) Co-authored-by: Sam Gross <[email protected]>
|
GH-148512 is a backport of this pull request to the 3.14 branch. |
colesbury
added a commit
that referenced
this pull request
Apr 13, 2026
… event (gh-148509) (#148512) The watcher-bits read in _PyDict_NotifyEvent needs to use acquire to synchronize with the release from PyDict_Watch so that the callback publication is visible before the callback is invoked. (cherry picked from commit 19f96f9) Co-authored-by: Sam Gross <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watcher-bits read in _PyDict_NotifyEvent needs to use acquire to synchronize with the release from PyDict_Watch so that the callback publication is visible before the callback is invoked.
PyDict_WatchandPyDict_Unwatchshould use atomic operations in the free threading build #148393