gh-148378: Allow multiple consecutive recording ops per macro op#148496
Open
cocolato wants to merge 3 commits intopython:mainfrom
Open
gh-148378: Allow multiple consecutive recording ops per macro op#148496cocolato wants to merge 3 commits intopython:mainfrom
cocolato wants to merge 3 commits intopython:mainfrom
Conversation
Member
|
@markshannon just an FYI, I asked for this because there are ops where we want to record > 1 value (e.g. BINARY_OP) and speculate on both with guards (e.g. see Pieter's other PR on _BINARY_OP_EXTEND). |
Fidget-Spinner
approved these changes
Apr 13, 2026
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
LGTM. Good tests. Will leave this open for one day in case anyone else wants to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.