Skip to content

Is monkeypatch_for_cert needed any more? #136

Description

@pfmoore

Nowadays, pip extracts the cert bundle from certifi to a temporary file (see #pip/10753). As far as I can see, monkeypatch_for_cert here does basically the same thing.

Could we just remove that function?

Activity

  1. pradyunsg commented on Jan 6, 2022

    @pradyunsg
    Member

    I think so. Someone can try this out, and ensure that it is indeed the case.

  2. pfmoore commented on Jan 6, 2022

    @pfmoore
    MemberAuthor

    I might have a go at that if & when I can work out how I'd test such a change... But if anyone else gets to it first, I won't object 🙂

  3. pradyunsg commented on Jan 6, 2022

    @pradyunsg
    Member

    FWIW, how to work on this repository for iterating on things like this:

    • Update the templates.
    • nox -s generate (regenerates the get-pip.py files)
    • nox -s check-3.9 (runs the relevant script in a clean venv)
  4. pradyunsg commented on Jan 6, 2022

    @pradyunsg
    Member

    I think things should blow up -- certifi should fail, IIUC -- if removing the whole monkeypatching thing isn't something the code can handle. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions