Skip to content

_parse_keep: make defensive and yield exception to respect error policy #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
purarue merged 1 commit into from
Jul 25, 2025
Merged

_parse_keep: make defensive and yield exception to respect error policy #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 39 additions & 36 deletions google_takeout_parser/parse_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,39 +291,42 @@ def _parse_keep(p: Path) -> Iterator[Res[Keep]]:
json_data = _read_json_data(p)
# For google keep, each note is stored as a separate json file,
# so technically there is always just one yield value
yield Keep(
title=json_data["title"],
created_dt=datetime.fromtimestamp(
json_data["createdTimestampUsec"] / 1_000_000, tz=timezone.utc
),
updated_dt=datetime.fromtimestamp(
json_data["userEditedTimestampUsec"] / 1_000_000, tz=timezone.utc
),
listContent=[
KeepListContent(
textHtml=content["textHtml"],
text=content["text"],
isChecked=content["isChecked"]
) for content in json_data.get("listContent", [])
],
textContent=(
json_data["textContent"]
if "textContent" in json_data else None
),
textContentHtml=(
json_data["textContentHtml"]
if "textContentHtml" in json_data else None
),
color=json_data["color"],
annotations=[
KeepAnnotation(
description=annotation["description"],
source=annotation["source"],
title=annotation["title"],
url=annotation["url"],
) for annotation in json_data.get("annotations", [])
],
isTrashed=json_data["isTrashed"],
isPinned=json_data["isPinned"],
isArchived=json_data["isArchived"]
)
try:
yield Keep(
title=json_data["title"],
created_dt=datetime.fromtimestamp(
json_data["createdTimestampUsec"] / 1_000_000, tz=timezone.utc
),
updated_dt=datetime.fromtimestamp(
json_data["userEditedTimestampUsec"] / 1_000_000, tz=timezone.utc
),
listContent=[
KeepListContent(
textHtml=content["textHtml"],
text=content["text"],
isChecked=content["isChecked"]
) for content in json_data.get("listContent", [])
],
textContent=(
json_data["textContent"]
if "textContent" in json_data else None
),
textContentHtml=(
json_data["textContentHtml"]
if "textContentHtml" in json_data else None
),
color=json_data["color"],
annotations=[
KeepAnnotation(
description=annotation["description"],
source=annotation["source"],
title=annotation["title"],
url=annotation["url"],
) for annotation in json_data.get("annotations", [])
],
isTrashed=json_data["isTrashed"],
isPinned=json_data["isPinned"],
isArchived=json_data["isArchived"]
)
except Exception as e:
yield e