Skip to content

Fix docker_compose up_args - #997

Open
mcarrolle wants to merge 6 commits into
puppetlabs:mainfrom
mcarrolle:fix-compose-upargs
Open

mcarrolle wants to merge 6 commits into
puppetlabs:mainfrom
mcarrolle:fix-compose-upargs

Conversation

@mcarrolle

@mcarrolle mcarrolle commented Sep 12, 2024 •

Copy link
Copy Markdown

Summary

Fix wrong position of up_args arguments passed to command and handle up_args argument that contains value like --pull always.
Issue: #984 and #996

Additional Context

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@mcarrolle
mcarrolle requested a review from a team as a code owner September 12, 2024 12:55
@KoenDierckx

Copy link
Copy Markdown

Any updates on this, it is blocking our upgrade of the module ?

@rogermartensson

Copy link
Copy Markdown

(I am not code owner)

I wonder if the argument validation for up_args is correct in the ruby-code for the docker_compose type?
Input should be an array but error says it should be a String.

I also notices that this pullrequests has failing CI-tests.

@jst-cyr

jst-cyr commented Jul 27, 2026

Copy link
Copy Markdown
Member

@mcarrolle : Is this still an issue for you? It looks like the CI tests originally failed and have since been cleared out. There are also now branch conflicts with latest. Would you be able to update this and resolve any CI results that fail for unit testing?

(Note that acceptance testing will not succeed due to current limitations on the testing matrix config)

# Conflicts:
#	lib/puppet/provider/docker_compose/ruby.rb
@mcarrolle

Copy link
Copy Markdown
Author

Hi @jst-cyr — yes, the issue is still present. I’ve updated the branch: the changes fixing the placement of the up_args arguments and handling up_args values as an Array. Could you re-run the tests or check again? Thanks for the review.

@jst-cyr

jst-cyr commented Aug 6, 2026 •

Copy link
Copy Markdown
Member

EDIT: CI tests did not run. Will try a new branch for running acceptance tests.

@jst-cyr

jst-cyr commented Aug 14, 2026

Copy link
Copy Markdown
Member

Running CI tests for this PR here: #1064

@jst-cyr

jst-cyr commented Aug 14, 2026 •

Copy link
Copy Markdown
Member

Acceptance testing results here: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/31843572009

All 4 failing platforms (CentOS-7, CentOS-8, Debian-10, Ubuntu-20.04) fail identically on the nightly build against main with the same failing step and same root cause (Docker yum repo outage on CentOS-7, provisioning-service 500s on CentOS-8/Ubuntu-20.04, and a Debian buster apt 404 on Debian-10). These are pre-existing infrastructure/environment issues, not regressions introduced by this PR.

@mcarrolle

Copy link
Copy Markdown
Author

@jst-cyr
Just checking in on this merge request. Is anything blocking it, or do you have any updates on its status ?

@jst-cyr

jst-cyr commented Nov 18, 2026

Copy link
Copy Markdown
Member

Hey @mcarrolle , this PR is still in the queue for review, though it's made it's way much closer to the top over the last several months. I see you've updated the codebase, and I know we had some acceptance failures due to lazy infrastructure so I'll refresh our testing for spec and acceptance tests just to double-check current state and make sure we are good state for review when this PR gets to the top of the list.

@jst-cyr

jst-cyr commented Nov 18, 2026

Copy link
Copy Markdown
Member

Tests for this PR are being executed in #1095

@jst-cyr

jst-cyr commented Nov 18, 2026

Copy link
Copy Markdown
Member

✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/44230788929?pr=1095

All green on testing, but still needs an engineering review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants