Repository navigation
Conversation
|
Any updates on this, it is blocking our upgrade of the module ? |
|
(I am not code owner) I wonder if the argument validation for up_args is correct in the ruby-code for the docker_compose type? I also notices that this pullrequests has failing CI-tests. |
|
@mcarrolle : Is this still an issue for you? It looks like the CI tests originally failed and have since been cleared out. There are also now branch conflicts with latest. Would you be able to update this and resolve any CI results that fail for unit testing? (Note that acceptance testing will not succeed due to current limitations on the testing matrix config) |
# Conflicts: # lib/puppet/provider/docker_compose/ruby.rb
|
Hi @jst-cyr — yes, the issue is still present. I’ve updated the branch: the changes fixing the placement of the |
|
EDIT: CI tests did not run. Will try a new branch for running acceptance tests. |
|
Running CI tests for this PR here: #1064 |
|
Acceptance testing results here: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/31843572009 All 4 failing platforms (CentOS-7, CentOS-8, Debian-10, Ubuntu-20.04) fail identically on the nightly build against main with the same failing step and same root cause (Docker yum repo outage on CentOS-7, provisioning-service 500s on CentOS-8/Ubuntu-20.04, and a Debian buster apt 404 on Debian-10). These are pre-existing infrastructure/environment issues, not regressions introduced by this PR. |
|
@jst-cyr |
|
Hey @mcarrolle , this PR is still in the queue for review, though it's made it's way much closer to the top over the last several months. I see you've updated the codebase, and I know we had some acceptance failures due to lazy infrastructure so I'll refresh our testing for spec and acceptance tests just to double-check current state and make sure we are good state for review when this PR gets to the top of the list. |
|
Tests for this PR are being executed in #1095 |
|
✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/44230788929?pr=1095 All green on testing, but still needs an engineering review. |
Summary
Fix wrong position of up_args arguments passed to command and handle up_args argument that contains value like
--pull always.Issue: #984 and #996
Additional Context
Related Issues (if any)
Checklist
puppet apply)