Skip to content

Allow --icc=false option for docker daemon - #995

Open
bjvrielink wants to merge 1 commit into
puppetlabs:mainfrom
bjvrielink:main
Open

bjvrielink wants to merge 1 commit into
puppetlabs:mainfrom
bjvrielink:main

Conversation

@bjvrielink

@bjvrielink bjvrielink commented Sep 5, 2024 •

Copy link
Copy Markdown

This used to be possible in version 9.1.0 and older, but got lost in translation from .erb to .epp templates.

Fixes #989

Summary

Changes 5 templates to use unless instead of if for the --icc parameter

Additional Context

If a user wants to specify the --icc parameter, they always will want to use --icc=false, as the default is true.
By using if $icc in the template, it is impossible to set -icc=false.

Related Issues (if any)

See issue #989

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@bjvrielink
bjvrielink requested a review from a team as a code owner September 5, 2024 12:33
@jst-cyr

jst-cyr commented Aug 31, 2026

Copy link
Copy Markdown
Member

My apologies, @bjvrielink that it took so long for somebody to reach out about this PR. I'm going through old PRs and discovered this one. I'm wondering if this is still a use case you need solved?

@bjvrielink

Copy link
Copy Markdown
Author

yes, please!

@jst-cyr

jst-cyr commented Sep 1, 2026

Copy link
Copy Markdown
Member

Test PR created to run CI against this change: #1069

@jst-cyr

jst-cyr commented Sep 1, 2026 •

Copy link
Copy Markdown
Member

Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/33518659925?pr=1069

CENTOS 7, CENTOS 8, Ubuntu 20.04, and Debian 10 are failing in a matching way to failures seen on the nightly CI against main. This PR doesn't seem to be introducing those failures.

Windows 2022, however, is failing in that PR even though it succeeded on the latest nightly runs. The failure doesn't seem related to the PR, given the connectivity issue that is showing in the logs, but I have tried to re-run it a few times and if it's a temporary network flakiness issue it doesn't seem to be resolving.

I'm going to leave that CI PR open for a bit and try rerunning again later to see if the networking issue has resolved, but we may need to dig into what is going on with Windows 2022 here.

@kyle-burnett

Copy link
Copy Markdown

Hey there @jst-cyr

Apologies for the direct ping, but I wanted to see if you've had time to come back to this PR (this bug is also hitting us after we upgraded to v10 of this module)

Thanks!

This used to be possible in version 9.1.0 and older, but got lost in
translation from .erb to .epp templates.

Fixes puppetlabs#989
@jst-cyr

jst-cyr commented Nov 21, 2026

Copy link
Copy Markdown
Member

Sorry, @kyle-burnett , we had prioritized this one lower down the list of PRs versus some of the other ones that are open across the set of modules so we hadn't circled back around to this one yet. That said, we have been trying to get the CI a little more stable and it's worth rechecking to see if things are cleared up. Thanks for pinging on this!

Now that you've hit the bug as well, that means we might want to raise priority a bit. For your scenario, what's your setup? I want to make sure we have you covered in the testing.

@jst-cyr

jst-cyr commented Nov 21, 2026

Copy link
Copy Markdown
Member

Tests are being executed for this PR in #1096

@jst-cyr

jst-cyr commented Nov 21, 2026

Copy link
Copy Markdown
Member

✅ Acceptance Test Results: https://github.com/puppetlabs/puppetlabs-docker/actions/runs/44859356460?pr=1096

All spec and acceptance tests have passed. Tests are good, still needs engineering review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpossible to disable icc with 10.x version of this module

3 participants