Repository navigation
(MODULES-12006) pdk update to pdk-templates main (8ca954f) - #1094
Merged
Merged
Conversation
Prepare .sync.yml for pdk update to pdk-templates main (8ca954f): set the hand edits to pdk-managed files that are still needed, so the template renders them, and drop settings main makes obsolete (the PR body lists each one kept or dropped). Co-Authored-By: Claude <noreply@anthropic.com>
Safe autocorrect (rubocop --autocorrect) of the offenses the pdk-templates main (8ca954f) rubocop profile adds, so the pdk update commit does not park them in .rubocop_todo.yml. Safe cops only: no behaviour change. Co-Authored-By: Claude <noreply@anthropic.com>
Run pdk update (PDK 4.0.1) against pdk-templates main at 8ca954f. Pure pdk output, plus .rubocop_todo.yml regenerated with `rubocop --auto-gen-config --no-exclude-limit` (kept as is when only its header would change). Co-Authored-By: Claude <noreply@anthropic.com>
span786
approved these changes
Nov 13, 2026
span786
left a comment
Contributor
There was a problem hiding this comment.
Thanks @imaqsood, this looks good.
I checked the parts a template update can quietly break:
- The acceptance flags in
ci.ymlandnightly.ymlmatchmainexactly (including--provision-prefer provision_service,--provision-exclude dockerand--arch-exclude arm). - The hand-disabled puppet-lint checks carry over, and
.rubocop.ymlinherits the regenerated.rubocop_todo.yml. - The
pdk updatecommit only touches template-managed files. Each hand edit listed as dropped is replaced by the template's own equivalent (puppetcore gem-source logic, per-source gem pins, conditional syntax-task requires). - CI is green, including the Puppet 9 / Ruby 4 spec lane and the static checks, and the branch is up to date with
main.
The autocorrect commit only touches specs: trailing commas, plus a <<- heredoc in compose_v3_spec.rb becoming <<~ with re-indented content that strips back to the same YAML.
Approving. I'll leave the merge to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdk update of puppetlabs/puppetlabs-docker to pdk-templates main (8ca954f), with PDK 4.0.1.
Jira: https://perforce.atlassian.net/browse/MODULES-12006 (epic MODULES-11997)
Commits
Hand edits kept in .sync.yml
strict_indentstays disabled (was in Rakefile)exec_idempotencystays disabled (was in Rakefile)params_not_optional_with_undefstays disabled (was in Rakefile)Hand edits dropped
gem "voxpupuli-puppet-lint-plugins", '~> 7.0', require: false(template main's pin/condition for voxpupuli-puppet-lint-plugins)gem "puppetlabs_spec_helper", '~> 9.0', require: false(template main's pin/condition for puppetlabs_spec_helper)require 'puppetlabs-syntax/tasks/puppetlabs-syntax'(template main requires puppetlabs-syntax when puppetlabs_spec_helper 9 loads it)Tests
cat-module(static, unit; full suite): real, 0 passed, 0 failed🤖 Generated with Claude Code