Skip to content

feat(#231): wire the wsc.facts value-range SOURCE (constants, masks, booleans) #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
Aug 13, 2026
Merged

feat(#231): wire the wsc.facts value-range SOURCE (constants, masks, booleans) #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions loom-cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,15 @@ fn optimize_command(
if &input_bytes[0..4] == b"\0asm" && input_bytes[4] == 0x0d && input_bytes[5] == 0x00 {
println!("🧩 Detected WebAssembly Component!");
println!("📦 Attempting component optimization...");
if emit_facts {
// #231: the component pipeline encodes its core modules
// internally and the fact source is not wired into it. Say so
// rather than let --facts look like it did something.
println!(
"⚠️ --facts is not wired into the component pipeline yet — \
no wsc.facts section will be emitted for this input (#231)."
);
}

// Use component optimization
let component_config = loom_core::ComponentOptimizeConfig {
Expand Down Expand Up @@ -548,8 +557,13 @@ fn optimize_command(
.into_bytes()
} else {
println!("📦 Encoding to WASM binary...");
// #231: the island winner carries its own module.facts (empty in
// P1 unless a fact-source injected them before island dispatch).
// #231 fact SOURCE: derive the facts from the island WINNER, here,
// immediately before the encode that consumes them — the operator
// keying is only valid against the body being encoded.
if emit_facts {
module.facts = loom_core::facts::collect_module_facts(&module);
println!("🔖 {} proof-carrying fact(s) collected", module.facts.len());
}
loom_core::encode::encode_wasm_with_facts(&module, emit_facts)
.context("Failed to encode to WASM")?
};
Expand Down Expand Up @@ -882,6 +896,12 @@ fn optimize_command(
} else {
println!("📦 Encoding to WASM binary...");
if emit_facts {
// #231 fact SOURCE: derive the facts from the FINAL module, here,
// immediately before the encode that consumes them — no pass runs
// in between, so no fact can be renumbered out from under its
// operator.
module.facts = loom_core::facts::collect_module_facts(&module);
println!("🔖 {} proof-carrying fact(s) collected", module.facts.len());
// #231: emit the wsc.facts custom section from module.facts, keyed
// to the FINAL operator sequence this same call encodes.
loom_core::encode::encode_wasm_with_facts(&module, true)
Expand Down
Loading
Loading