Repository navigation
Fetch origin Once Before decision-triage's History Check - #3763
Conversation
The classifier's overtaken check and the researcher's on-main test both read origin/main, and the check also reads develop for a HELD issue. A stale remote-tracking ref reads an overtaken issue as HELD or as open work, so both now fetch immediately before reading and stop on a failed fetch. Answers promotion #3762's first review round. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The subagents are read-only and run four at a time, so a fetch in each broke their write bound and raced on the checkout's ref locks. The triaging session now fetches main and develop once before dispatching, and the history check reads the full remote-tracking refs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
A recorded local strict-review pass covers head |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain, and the change consistently applies the required remote-ref fetching and history-check updates across the canonical and generated skill files.
No open issues 🎉
What changed in this PR
This pull request updates decision-triage to fetch fresh remote-tracking refs before history-based classification and research, preventing stale branch data from misclassifying issues.
Changes:
- Fetches
origin/mainandorigin/developbefore classifier and researcher dispatches. - Prevents subagents from fetching concurrently and stops when fetching fails.
- Uses fully qualified remote-tracking refs for history checks.
- Regenerates the GitHub and Claude skill distributions and updates the source digest.
This pull request requires changes.
| File | Description |
|---|---|
.github/skills/decision-triage/SKILL.md |
Generated GitHub Copilot skill distribution. |
.claude-plugin/fleet-skills/skills/decision-triage/SKILL.md |
Generated Claude skill distribution. |
.claude-plugin/fleet-skills/.source-digests/decision-triage |
Updated source digest for the generated skill. |
.agents/skills/decision-triage/SKILL.md |
Canonical decision-triage workflow with fetch and full-ref history-check requirements. |
Review effort: Lite
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3763 +/- ##
========================================
Coverage 82.31% 82.31%
========================================
Files 28 28
Lines 9438 9438
========================================
Hits 7769 7769
Misses 1669 1669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…Fetch Before Its History Check (#3762) Promotes the changes merged into `develop` since promotion #3736 to `main`. - [#3760](#3760) improves `decision-triage` from its first full run: - Researchers take topic clusters, and step 3 states the researcher count and a token estimate before dispatching. - The researcher brief reads every comment newest last, says its output is posted publicly, and bounds writes to a scratch directory of its own. - The classifier can return `OVERTAKEN` after a cheap history check, and a new step offers to close overtaken issues. - Coupled questions are asked in one prompt. - A new `deferred` label marks a "not yet" answer, which the classifier and `backlog-burndown` skip and report by count. - A recorded maintainer approval lets an attended run implement an agent-safety edit, with the merge still waiting on a per-PR go-ahead. - [#3763](#3763) has the triaging session fetch `main` and `develop` once before dispatching the history check and the researchers, and stop if the fetch fails. The subagents read the full remote-tracking refs and fetch nothing. It answers this promotion's first review round. After the release, the maintainer runs `repo-config/configure.sh apply ptr727/ProjectTemplate` to create the `deferred` label, then labels #781, #1464 and #2174 `deferred`, per #3760's "After Merge". Deferred review findings: #3761 (an attended `backlog-burndown` run applies no agent-safety hold to an unapproved issue). Fixes #3759 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Answers the first review round on promotion #3762.
decision-triage's history check readorigin/mainwithout fetching it, so a stale remote-tracking ref could read an overtaken issue asHELD, or aHELDone as open work.Changes
git fetch origin main developonce, and stops and reports if it fails. It repeats the fetch before step 3's researchers.refs/remotes/origin/mainandrefs/remotes/origin/developby full ref, aslocal-strict-review"What It Does" does, so a local branch namedorigin/maincannot stand in for the remote one..github/skills/and.claude-plugin/withbuild_dist.py.Local Review
Two
frontierpasses ran. The first raised six findings against an earlier version that fetched inside each subagent. Those findings were the write-bound conflict, the concurrent-fetch race, a stop with no return line, a pronoun that lost its antecedent, an overstated rationale, and the short ref form. One edit round fixed all six. The second pass, over 6ed54073, found nothing (COUNT 0) and is recorded.Declined findings
.agents/skills/decision-triage/SKILL.mdsteps 2 and 3 (style): the new text says "the triaging session" where "The Seats" defines "the triage seat". That section defines the seat as the session the skill runs in, so either name finds the same actor. Declined as a preference perfleet-code-review"Review the Change".🤖 Generated with Claude Code