[ptr727]

Promotes the changes merged into develop since promotion #3703 to main, the third round of a backlog burndown.

• #3709 Reads a push's remote, and the branch of a push with no refspec, in the repository git actually uses in the write guard's owner check (requirement 4). Before, --git-dir and a GIT_DIR on the push were ignored, so a constructed git --git-dir=<other>/.git push origin develop was checked against the working directory's repository rules and allowed. A shape whose repository the guard cannot determine (an earlier GIT_DIR, a -c or --config-env override of a remote. or url. key, any GIT_CONFIG* variable, an unresolvable --git-dir) now blocks main, master and develop. The self-test covers each shape and host-setup/agent-safety/README.md states the requirement.

• #3712 Reads a file moved out of a source some rule never read in full for that rule in the prose gate: a narrowed directory scope, a home_path_exempt file, instruction text for issue-ref, and a move that changes the file's lexer. Skips YAML block scalars when reading a Compose file's volume entries.

• #3707 Names uv's no-cache setting, and its remedies, when the repo gate's resolved PyYAML interpreter is gone at launch, rather than reporting a bare missing-file error.

• #3708 Moves the section-name lookup key into one section_key() in spec/fidelity_text.py, used by the carry, the audit, the skill build and the review ledger, with no behavior change.

• #3722 Applies env's directory and environment options to the command the write guard judges, answering this promotion's first review round: env -C/--chdir move the repository a relative GIT_DIR and the remote resolve in, env -i/-u clear a GIT_DIR that no longer steers the check, and env -S is read rather than skipped. A run-time directory reads as undetermined, which blocks main, master and develop.

• #3721 Finds a Compose block-scalar opener through the YAML lexer the gate already uses rather than a hand-written pattern, so a key holding #, quoted or not, opens the opaque region. Also answers this promotion's first review round.

• #3727 Reads an env option the write guard does not recognize, such as GNU env's --ch abbreviation of --chdir, as leaving the push's repository undetermined, so main, master and develop fail closed, answering this promotion's second review round. A feature-branch push is never newly blocked.

• #3731 Removes the fallback Read an Unrecognized env Option as an Undetermined Directory in the Write Guard #3727 kept for a push naming no refspec behind an unrecognized env option, answering this promotion's third review round. Such a push resolves its branch only through an absolute --git-dir, git's own -C, or a cd in a wrapper body, and is otherwise read as writing every protected default, so it fails closed even from a feature branch.

Deferred review findings: #3705 (scripts/README.md's uvx promise), #3706 (validate.py's exact section-name match), #3710 (whether section_key should casefold), #3711 (Compose-name and directory moves in the prose gate), #3713 (the review reader's open review findings: spelling), #3714 (an edited shebang that changes a file's lexer), #3720 (the write guard's reading of git push -o<value>), #3723 (unused _bare_push_branch parameters), #3729 (a bare push after a branch switch earlier in the same command), #3732 (the review reader's Review findings remain: spelling).

For the maintainer: #3730 asks whether every bare push whose repository the guard cannot determine should fail closed, as #3731 now does behind an unrecognized env option.

Fixes #3695
Fixes #3684
Fixes #3694
Fixes #2358
Fixes #3686
Fixes #3716
Fixes #3717
Fixes #3725
Fixes #3728

🤖 Generated with Claude Code

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: ptr727/ProjectTemplate
• Branch: develop
• File: .coderabbit.yaml
• Commit: 5ad2acf
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 00c73463-68af-4e21-9262-5e9f18715145

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[Copilot]

🟡 Changes recommended

A critical active finding remains because env directory changes can cause the guard to resolve and validate the wrong repository, owner, or branch instead of failing closed.

1 open issue

• Apply env directory changes before resolving GIT_DIR · New

What changed in this PR

This pull request promotes the third backlog-burndown round from develop to main, improving push repository resolution, prose-gate move and YAML handling, uv diagnostics, and shared section-name normalization.

Changes:

• Resolve push remotes and branches from Git’s effective repository configuration, failing closed when unresolved.
• Expand prose-gate handling for moved files and skip Compose block-scalar contents during volume analysis.
• Clarify uv no-cache interpreter failures.
• Centralize section-name lookup through section_key().
• Outstanding findings:
  • Critical: env -C and env --chdir changes are not reflected when resolving GIT_DIR.
  • Moderate: valid YAML mapping keys containing # are not recognized by block-scalar detection.

File	Description
tests/​test_repo_gate.py	Tests uv interpreter startup diagnostics.
tests/​test_prose_lint.py	Tests moved-file scope and Compose scalar handling.
tests/​test_fidelity_text.py	Tests section-key normalization.
spec/​fidelity_text.py	Adds the shared section-name lookup helper.
spec/​audit.py	Uses the shared section key for section presence checks.
spec/​audit_markdown.py	Uses the shared section key across Markdown checks.
scripts/​carry.py	Routes carry section folding through the shared helper.
scripts/​canonical_review.py	Uses the shared helper for review-unit matching.
scripts/​build_dist.py	Uses the shared helper for include heading lookup.
OPERATIONS.md	Documents the section-key primitive.
host-setup/​agent-safety/​README.md	Documents push repository and branch resolution behavior.
host-setup/​agent-safety/​claude/​gh-write-guard.py	Resolves push repositories and branches from Git options and command environments.
.github/​actions/​repo-gate/​repo_gate.py	Explains missing uv-resolved interpreters caused by no-cache settings.
.github/​actions/​prose-gate/​prose-gate.json	Declares rule-specific file exemption metadata.
.github/​actions/​prose-gate/​prose_lint.py	Adds per-rule moved-file scope handling and Compose block-scalar skipping.

This pull request requires changes.

_{Review effort: Lite}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.02%. Comparing base (b30ce55) to head (5ad2acf).
⚠️ Report is 454 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3715   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files          27       27           
  Lines        9273     9275    +2     
=======================================
+ Hits         7606     7608    +2     
  Misses       1667     1667           

Flag	Coverage Δ
python-3.13	82.02% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ptr727]

Answering the first round's outstanding findings on 27870ae. Critical, env -C/env --chdir not reflected when resolving GIT_DIR: fixed in #3722 (8d71126), answered on its thread. Moderate, a YAML mapping key containing # not recognized by block-scalar detection: reproduced and fixed in #3721 (5f04434). The Compose reader now finds block-scalar openers through the YAML lexer the gate already uses, so x-a#b: |, "x #b": | and 'x # b': | all open the opaque region; a fuzz of about 15,000 generated documents matched PyYAML's block-scalar rows exactly. Tracked as #3717. Both fixes are in this head.

[Copilot]

🟡 Changes recommended

A critical active finding remains because unambiguous GNU env long-option prefixes can bypass the guard’s command analysis and allow an unsafe git push.

1 open issue

• Recognize unique abbreviations of env long options · New

1 resolved since last review

• Apply env directory changes before resolving GIT_DIR

_{Review effort: Lite}

[Copilot]

🟡 Changes recommended

A critical active finding shows that an unknown environment option can cause a protected-branch push to be incorrectly allowed, requiring changes before approval.

1 open issue

• Do not re-anchor protected-branch checks through unknown env options · New

1 resolved since last review

• Recognize unique abbreviations of env long options

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because a critical hidden finding indicates that multiple ordered env -C directory changes are mishandled, potentially applying the wrong remote and branch rules.

No open issues 🎉

1 resolved since last review

• Do not re-anchor protected-branch checks through unknown env options

_{Review effort: Lite}

[ptr727]

Answering the round's needs a closer look headline on 5ad2acf, which counts no finding and names one: "multiple ordered env -C directory changes are mishandled, potentially applying the wrong remote and branch rules." Declined, the claim does not reproduce.

Ground truth from GNU coreutils env, run against constructed directories: within one env only the last -C takes effect, relative to the starting directory (env -C a -C b pwd gives s/b), and separate env launchers stack (env -C a env -C b pwd gives s/a/b). The guard models exactly that: _launch overwrites chdir within one env, appends one entry to chdirs per launcher, and _moved composes those entries and then any git -C values in order.

Checked with three constructed repositories whose origin names a different owner (alpha/x on main requiring a pull request, beta/y nested inside it, gamma/z alongside), classifying each command through the guard's real resolution path and comparing the owner, the branch a no-refspec push writes, and both verdicts with what git remote get-url --push origin and git rev-parse --abbrev-ref HEAD give under the same launcher text. All 33 shapes where git resolves a repository match, covering stacked env launchers, several -C or --chdir in one env, env -C mixed with git -C, cd and sh -c, relative GIT_DIR set before or after the -C, and env -i/-u. The alpha main cases are denied for both an explicit and a no-refspec push.

A separate, pre-existing question surfaced while checking (a no-refspec push whose branch the guard cannot read for a reason other than an unrecognized env option is allowed) is recorded on #3730, which already asks it.