Skip to content

State the PowerShell -Help and -h Form in Command-Line Arguments - #3652

Merged
ptr727 merged 3 commits into
developfrom
feature/auto-3602
Oct 30, 2026
Merged

ptr727 merged 3 commits into
developfrom
feature/auto-3602

Conversation

@ptr727

@ptr727 ptr727 commented Oct 30, 2026

Copy link
Copy Markdown
Owner

Summary

CODESTYLE.md "Command-Line Arguments" required every command-line script to answer --help and -h. A PowerShell script declaring its own parameters takes the -Help switch with an h alias instead, as the hub's own host-setup scripts do, so a literal --help reached the unknown-argument path. Read literally, the rule put every such script in breach. The maintainer already chose to keep the PowerShell form, so this changes the rule text only.

  • Bullet 1 now says a PowerShell script declaring its own parameters answers -Help and -h and owes no answer to a literal --help. A wrapper forwarding its arguments to another script answers whatever that script answers.
  • Bullet 2 now says such a script refuses a literal --help like any other unrecognized argument. The binder does that where no parameter takes the remaining arguments. A script with such a parameter refuses a dash-prefixed leftover itself, as install-agents.ps1, install-tools.ps1, and setup-wsl.ps1 already do.
  • The python-codestyle and shell-codestyle Skills carry the section as a generated include, regenerated with scripts/build_dist.py.

Verification

  • uv run --no-project --script scripts/build_dist.py --check reports the generated distributions current.
  • The .husky/pre-commit gate passes, prose lint included.
  • Three local-strict-review passes ran. The first two found claims the hub's own scripts contradicted: the remaining-arguments scripts and the two forwarding wrappers. Both were fixed. The third found nothing.

Closes on promotion: #3602

🤖 Generated with Claude Code

A PowerShell script answers -Help and -h from a -Help switch with an h
alias, and its parameter binder refuses a literal --help like any other
unbound argument. CODESTYLE.md "Command-Line Arguments" now says so, so
the rule and the hub's own PowerShell scripts agree. The python-codestyle
and shell-codestyle Skills carry the section as a generated include and
are regenerated.
Copilot AI lite review requested due to automatic review settings October 30, 2026 09:28
@ptr727

ptr727 commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 60d0a7939cff34bd06262a62189d8640b52c541f, the content this pull request carries at that commit against develop, and it recorded 0 findings.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the change only clarifies the help-flag rule in CODESTYLE.md and its generated Skill copies without modifying any scripts.

No open issues 🎉

What changed in this PR

This PR clarifies the command-line argument rule in CODESTYLE.md. The rule said every command-line script must answer --help and -h. PowerShell scripts that declare their own parameters answer -Help and -h instead, so a literal --help reaches the binder's unknown-argument refusal. The PR states that form in the rule text and keeps the generated Skill copies in step. It changes no scripts.

Changes:

  • CODESTYLE.md now says PowerShell scripts with their own parameters answer -Help and -h, and refuse a literal --help as an unrecognized argument.
  • The python-codestyle and shell-codestyle Skills carry the same text as generated copies, and their source digests are updated to match.
File Description
CODESTYLE.md Source of the rule. Adds the PowerShell -Help and -h form and the unknown-argument carve-out to both bullets.
.github/​skills/​shell-codestyle/​SKILL.md Generated copy of the shell section. Carries the same text.
.github/​skills/​python-codestyle/​SKILL.md Generated copy of the Python section. Carries the same text.
.claude-plugin/​fleet-skills/​skills/​shell-codestyle/​SKILL.md Generated plugin copy of the shell section. Carries the same text.
.claude-plugin/​fleet-skills/​skills/​python-codestyle/​SKILL.md Generated plugin copy of the Python section. Carries the same text.
.claude-plugin/​fleet-skills/​.source-digests/​shell-codestyle Updates the digest so it matches the regenerated shell skill tree.
.claude-plugin/​fleet-skills/​.source-digests/​python-codestyle Updates the digest so it matches the regenerated Python skill tree.
.agents/​skills/​shell-codestyle/​SKILL.md Hand-authored source copy of the shell section. Carries the same text.
.agents/​skills/​python-codestyle/​SKILL.md Hand-authored source copy of the Python section. Carries the same text.

Review effort: Lite

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.70%. Comparing base (b38e084) to head (60d0a79).
⚠️ Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3652      +/-   ##
===========================================
+ Coverage    81.60%   81.70%   +0.09%     
===========================================
  Files           26       26              
  Lines         9070     9119      +49     
===========================================
+ Hits          7402     7451      +49     
  Misses        1668     1668              
Flag Coverage Δ
python-3.13 81.70% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit f308185 into develop Oct 30, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/auto-3602 branch October 30, 2026 09:41
ptr727 added a commit that referenced this pull request Oct 30, 2026
…Session Prompt Rules (#3667)

Promotes the changes merged into `develop` since promotion #3636 to
`main`.

- [#3640](#3640) Pins the
validator's `uvx ruff` to a Dependabot-managed manifest.
- [#3642](#3642) Counts
Copilot findings under the unresolved bullet and the file table.
- [#3644](#3644) Aligns
the split comment copies and drops the stale counts.
- [#3646](#3646) Sends a
command meant for the session's input line in a plain message, never in
a blocking prompt.
- [#3648](#3648) Opens the
attended session by cloning a hub checkout of the session's own.
- [#3650](#3650) Reads a
held package as installed in both Linux host scripts.
- [#3652](#3652) States
the PowerShell `-Help` and `-h` form in the command-line argument rules.
- [#3654](#3654) Counts
sentences in Markdown table cells for the sentence-length check.
- [#3658](#3658) Splits a
table row only at an unescaped pipe in the semicolon rule.
- [#3660](#3660) Finds
table cell boundaries before blanking code spans and quotations.
- [#3662](#3662) Names a
stale job record on a completed run in `pr_review.py`.
- [#3665](#3665) Keeps a
line holding code after a block comment's closer out of `comment-added`.
Its squash commit on `develop` carries the pull request's original
title, which names a heredoc reading. That reading was withdrawn before
the merge on decision #3666, so a workflow `run:` heredoc body still
reads as code.
- [#3669](#3669) Counts
each `[Pn]` marker in a Copilot Findings cell, so a second finding in
one cell is no longer dropped from triage. It answers one of the two
findings Copilot raised on this promotion. The other is declined with a
parser probe in its thread.

Closes #3616
Closes #3610
Closes #3622
Closes #3638
Closes #3604
Closes #3511
Closes #3602
Closes #3456
Closes #3655
Closes #3657
Closes #3362
Closes #1664

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants