V2 - Add config for DictAble and option to auto strip string - #49
Open
gowthamvbhat wants to merge 2 commits into
Open
V2 - Add config for DictAble and option to auto strip string#49gowthamvbhat wants to merge 2 commits into
gowthamvbhat wants to merge 2 commits into
Conversation
Collaborator
Author
|
V1 implementation - #48 |
pskd73
requested changes
Nov 16, 2024
| fields[attr[0]] = attr[1] | ||
| for name, th in get_type_hints(cls).items(): | ||
| if name not in fields: | ||
| if name not in fields and th not in _IGNORE_TYPES: |
Owner
There was a problem hiding this comment.
Can we call it ignore keys or ignore attributes?
| value = d.get(self.get_field_key(attr)) | ||
| if not field.required and value is None: | ||
| continue | ||
| field.config = self._config |
Owner
There was a problem hiding this comment.
Instead of assigning it, can we pass it while running the field? To from_dict or to_dicts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired from
ConfigDict -> str_strip_whitespacefrom Pydantic - https://docs.pydantic.dev/latest/api/config/#pydantic.config.ConfigDict.str_strip_whitespace