refactor(bayn): totalize evidence core - #13349
Merged
Merged
Conversation
gregkonush
force-pushed
the
codex/bayn-total-evidence-core
branch
from
July 28, 2026 09:12
2570172 to
23de744
Compare
Member
Author
|
|
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
|
Exact-head review/CI disposition before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
None.
Compatibility and scope evidence
3a2d6aad649a5ec935b6efc291273f0818628ca5.{"a":{"10":1,"2":2},"z":[null,true,false,0,1.25,"é","😀"]}with SHA-256eb5c6929cd35d9590df65fb9db0caf13177df754b1d99e17c8d58e30735486c9.PersistenceMismatchwithout writes; terminal constraint failure rolls back every evidence table.gh pr diff --name-onlyfor refactor(bayn): make qualification decisions explicit #13342, refactor(bayn): extract autonomous cycle reconciliation core #13344, and test(bayn): add real Alpaca sandbox contract proof #13325 immediately before commit: zero changed-path overlap. No execution, broker, config/application, risk/capital-authority schema, strategy/market-data, workflow/Nix/GitOps, qualification, cycle, or reconciliation path is changed.depsSourcemanifest or patch input, preserving the existing Bayn fixed-output dependency hash without touching excluded Nix files.Metrics
Changed production surface, before → after:
Effect.gen: 16 → 13.throw: 0 → 0;OperationalError: 0 → 0;Result.try: 2 → 2, limited to typed hostile-reflection/crypto containment.evidence-store/boundary; added one cohesive replay identity edge and consolidated typed database-error mapping.Testing
bun run lintbun run lint:oxlintbun run lint:oxlint:typebun run lint:effect— 331/331 files, zero errors, warnings, or messages.bun run tscbun run build— 679 modules bundled.bun run test— 820 passed, 0 failed, 122 PostgreSQL-gated tests skipped.BAYN_TEST_POSTGRES_URL=postgresql://postgres@127.0.0.1:55432/bayn_total_evidence_test bun run test:postgresagainst an isolated local-forwarded test database — 114 passed, 0 failed: cycle observability 5, evidence store 66, accounting persistence 30, cycle store 13.Breaking Changes
None. The removed canonical JSON aliases and EvidenceStore test constructor had no active production callers; the retained canonical hash compatibility alias still serves active out-of-scope callers.
Checklist