You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am trying to use sidekiq-runner and my sidekiq.yml include the queue list. This change will fetch that information from the yml and apply it in the instance configuration.
the idea behind this separation of queue configuration and process configuration was to be able to keep the "business logic" side part of the code base (i.e. what queues are used, what's their weight, etc.), whereas settings used only to control a particular deployment (concurrency, logfiles/pidfiles, ...) a config option for sidekiq.yml. In particular, we wanted to ensure that some options from the code base are not allowed to be overwritten in the config file at all (hence the explicit CONFIG_FILE_ATTRIBUTES), including the queue configuration.
Having said that, there's of course no real argument against exposing everything in the single deployment case for example.
An idea: How about exposing everything / particular additional settings (:queues) conditionally, based on a in-codebase option? For example, there could be an .expose_internals! method on the configuration object passed to the .configure block. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to use sidekiq-runner and my sidekiq.yml include the queue list. This change will fetch that information from the yml and apply it in the instance configuration.