[dogancanbakir]

Fixes #1975

Second wait loop now checks the received error like the first one, which golangci-lint v2.15 errcheck requires.

Summary by CodeRabbit

• Tests
  • Improved concurrency test validation by reporting worker completion errors instead of silently ignoring them.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: e7b5b04e-fc27-4cf2-bdcb-36ac631482ec

📥 Commits

Reviewing files that changed from the base of the PR and between b9239ac and 4ec329b.

📒 Files selected for processing: 1

• pkg/resolve/concurrency_test.go

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The pool-draining test now checks completion errors from pool workers and fails when any worker returns a non-nil error.

Changes

Concurrency test error handling

Layer / File(s)	Summary
Check pool worker errors pkg/resolve/concurrency_test.go	The test checks each worker's completion error and fails when it is non-nil.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other · Severity of issue fixed: Medium

Suggested reviewers: dwisiswant0

Merge Risk: ⚪ Minimal · up to 4ec32

The lint fix is limited in scope and presents no established merge-blocking risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: checking errors received from the concurrency test's done channel.
Linked Issues check		Issue #1975 requires the unchecked error receive from <-done in pkg/resolve/concurrency_test.go to be handled. The PR changes the second wait loop to assign the received error and call `t.Fatal(er…
Out of Scope Changes check		The diff changes only the completion-error handling in TestSharedLookupLimit. The change directly supports issue #1975 and adds no unrelated behavior or files.

Full details: Linked Issues check

Explanation

Issue #1975 requires the unchecked error receive from <-done in pkg/resolve/concurrency_test.go to be handled. The PR changes the second wait loop to assign the received error and call t.Fatal(err) when it is non-nil. This satisfies the stated errcheck requirement.

✨ Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{A rabbit checks each worker's note
For errors hiding in the flow
If one comes back with trouble found
The test will mark it clearly now
Then hops away with ears held high}

_{Comment @coderabbitai help to get the list of available commands.}